On Wed, 2012-02-15 at 16:52 -0500, Jörn Engel wrote: > transport_kmap_data_sg can return NULL. I never saw this trigger, but > returning -ENOMEM seems better than a crash. Also removes a pointless > case while at it. > > Signed-off-by: Joern Engel <joern@xxxxxxxxx> > --- > drivers/target/target_core_device.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c > index 9a6ca18..c8e4e52 100644 > --- a/drivers/target/target_core_device.c > +++ b/drivers/target/target_core_device.c > @@ -653,7 +653,9 @@ int target_report_luns(struct se_task *se_task) > unsigned char *buf; > u32 cdb_offset = 0, lun_count = 0, offset = 8, i; > > - buf = (unsigned char *) transport_kmap_data_sg(se_cmd); > + buf = transport_kmap_data_sg(se_cmd); > + if (!buf) > + return -ENOMEM; > > /* > * If no struct se_session pointer is present, this struct se_cmd is Applied. Thanks! -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
