Re: [PATCH 0/4] INQUIRY handling fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2012-02-13 at 16:18 -0800, Roland Dreier wrote:
> From: Roland Dreier <roland@xxxxxxxxxxxxxxx>
> 
> Hi Nic,
> 
> Here is a series of fixes for INQUIRY handling.  The main things are
> using a temp buffer to avoid all the buggy checking of cmd->data_length in
> the INQUIRY emulation, and adding a separate fabric_max_sectors
> attribute to fix up the maximum transfer length returned in our block
> limits VPD page.  The other two patches are pretty minor fixlets.
> 
> These patches are against Linus's latest tree, let me know if you want
> me to merge them up to lio-core-2.6.git.
> 
> Roland Dreier (4):
>   target: Fix up handling of short INQUIRY buffers
>   target: Set peripheral device type consistently in IQUIRY response
>   target: Don't set WBUS16 or SYNC bits in INQUIRY response
>   target: Untangle front-end and back-end meanings of max_sectors
>     attribute
> 
>  drivers/target/target_core_cdb.c       |  172 +++++++++-----------------------
>  drivers/target/target_core_configfs.c  |    4 +
>  drivers/target/target_core_device.c    |   65 +++++++++++-
>  drivers/target/target_core_internal.h  |    1 +
>  drivers/target/target_core_transport.c |    8 ++
>  include/target/target_core_base.h      |    5 +-
>  6 files changed, 123 insertions(+), 132 deletions(-)
> 

This series looks good to address the long standing INQUIRY length
handling issues.  Also, the addition of fabric_max_sectors in PATCH #4
makes sense to separate the use wrt to block limits VPD..

Applied to lio-core/master with some minor fuzz in PATCH #1.

I'll get these merged into target-pending/for-next in the next days.

Thanks alot Roland!

--nab


--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux