se_dev_entry.deve_cmds needed?

[Roland Dreier <roland@xxxxxxxxxxxxxxx>]

Hey Nico,

The only places I can find that refer to struct se_dev_entry.deve_cmds are:

void core_dec_lacl_count(struct se_node_acl *se_nacl, struct se_cmd *se_cmd)
{
	struct se_dev_entry *deve;
	unsigned long flags;

	spin_lock_irqsave(&se_nacl->device_list_lock, flags);
	deve = &se_nacl->device_list[se_cmd->orig_fe_lun];
	deve->deve_cmds--;
	spin_unlock_irqrestore(&se_nacl->device_list_lock, flags);
}

and

int transport_lookup_cmd_lun_cdb(struct se_cmd *se_cmd, u32
unpacked_lun, unsigned char *cdb)
{
...
		deve->deve_cmds++;
...
}

is this a remnant of something old, or is there a plan to use it for something?

Also does anything make sure we don't call core_free_device_list_for_node() with
commands in flight?

 - R.
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html