Looks good to me. Reviewed-by: Andy Grover <agrover@xxxxxxxxxx> On 02/03/2012 10:40 PM, Dax Kelson wrote: > Use IP_FREEBIND socket option so that iscsi portal configuration with > explicit IP addresses can happen during boot, before network interfaces > have been assigned IPs. > > This is especially important on systemd based Linux boxes where system > boot happens asynchronously and non-trivial configuration must be done > to get targetcli.service to start synchronously after the network is > configured. > > Reference: > http://lists.fedoraproject.org/pipermail/devel/2011-October/158025.html > > Signed-off-by: Dax Kelson <dkelson@xxxxxxxxxxxx> > Cc: "Nicholas A. Bellinger" <nab@xxxxxxxxxxxxxxx> > Cc: "Andy Grover" <agrover@xxxxxxxxxx> > Cc: "Lennart Poettering" <lennart@xxxxxxxxxxxxxx> > --- > drivers/target/iscsi/iscsi_target_login.c | 8 ++++++++ > 1 files changed, 8 insertions(+), 0 deletions(-) > > diff --git a/drivers/target/iscsi/iscsi_target_login.c b/drivers/target/iscsi/iscsi_target_login.c > index ec47a7c..38cb7ce 100644 > --- a/drivers/target/iscsi/iscsi_target_login.c > +++ b/drivers/target/iscsi/iscsi_target_login.c > @@ -842,6 +842,14 @@ int iscsi_target_setup_login_socket( > goto fail; > } > > + ret = kernel_setsockopt(sock, IPPROTO_IP, IP_FREEBIND, > + (char *)&opt, sizeof(opt)); > + if (ret < 0) { > + pr_err("kernel_setsockopt() for IP_FREEBIND" > + " failed\n"); > + goto fail; > + } > + > ret = kernel_bind(sock, (struct sockaddr *)&np->np_sockaddr, len); > if (ret < 0) { > pr_err("kernel_bind() failed: %d\n", ret); -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
