I'm not 100% sure this fix is correct (uncertainty caused by sess->session_reinstatement == 1) but barring extreme code subtlety it looks wrong. Signed-off-by: Andy Grover <agrover@xxxxxxxxxx> --- drivers/target/iscsi/iscsi_target_configfs.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/target/iscsi/iscsi_target_configfs.c b/drivers/target/iscsi/iscsi_target_configfs.c index 3468caa..ec7420a 100644 --- a/drivers/target/iscsi/iscsi_target_configfs.c +++ b/drivers/target/iscsi/iscsi_target_configfs.c @@ -1682,7 +1682,7 @@ static void lio_tpg_release_fabric_acl( /* * Called with spin_lock_bh(struct se_portal_group->session_lock) held.. * - * Also, this function calls iscsit_inc_session_usage_count() on the + * Also, this function calls iscsit_dec_session_usage_count() on the * struct iscsi_session in question. */ static int lio_tpg_shutdown_session(struct se_session *se_sess) @@ -1699,7 +1699,7 @@ static int lio_tpg_shutdown_session(struct se_session *se_sess) atomic_set(&sess->session_reinstatement, 1); spin_unlock(&sess->conn_lock); - iscsit_inc_session_usage_count(sess); + iscsit_dec_session_usage_count(sess); iscsit_stop_time2retain_timer(sess); return 1; -- 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
