On Thu, Feb 02, 2012 at 11:12:15AM -0800, Roland Dreier wrote: > On Thu, Feb 2, 2012 at 11:01 AM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > > + ? ? ? if (sg_num) > > + ? ? ? ? ? ? ? sg_num = BIO_MAX_PAGES; > > I think you meant something like > > sg_num = min(sg_num, BIO_MAX_PAGES); > > right? More or less, yes. And the sad part is that this still passed my testing. -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html