[PATCH 24/24] Fix horribly botched fabricmodule setup method

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Also, document.

Reported-by: Dax Kelson <dkelson@xxxxxxxxxxxx>
Signed-off-by: Andy Grover <agrover@xxxxxxxxxx>
---
 rtslib/target.py |   13 +++++++++----
 1 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/rtslib/target.py b/rtslib/target.py
index dcc5ca3..4d64877 100644
--- a/rtslib/target.py
+++ b/rtslib/target.py
@@ -360,10 +360,15 @@ class FabricModule(CFSNode):
     version = property(_get_version,
                        doc="Get the fabric module version string.")
 
-    def setup(self, **fm):
-            del fm['name']
-            for name, value in fm.iteritems():
-                setattr(fm_obj, name, value)
+    def setup(self, fm):
+        '''
+        Setup fabricmodule with settings from fm dict.
+        Returns int of how many nonfatal errors were encountered
+        '''
+        del fm['name']
+        for name, value in fm.iteritems():
+            setattr(self, name, value)
+        return 0
 
     def dump(self):
         d = super(FabricModule, self).dump()
-- 
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux