Block backstore should have better performance, although there are some use cases for this still, so we need to allow it. Signed-off-by: Andy Grover <agrover@xxxxxxxxxx> --- targetcli/ui_backstore.py | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/targetcli/ui_backstore.py b/targetcli/ui_backstore.py index 2733888..4dcb6e7 100644 --- a/targetcli/ui_backstore.py +++ b/targetcli/ui_backstore.py @@ -252,7 +252,7 @@ class UIFileIOBackstore(UIBackstore): % (size, buffered)) is_dev = get_block_type(file_or_dev) is not None \ or is_disk_partition(file_or_dev) - + if size is None and is_dev: backstore = FileIOBackstore(self.next_hba_index(), mode='create') try: @@ -264,6 +264,7 @@ class UIFileIOBackstore(UIBackstore): raise exception self.shell.log.info("Created fileio %s with size %s." % (name, size)) + self.shell.log.info("Note: block backstore preferred for best results.") ui_so = UIStorageObject(so, self) return self.new_node(ui_so) elif size is not None and not is_dev: -- 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html