On Fri, 2012-01-13 at 22:03 +0100, Sebastian Andrzej Siewior wrote: > On 01/13/2012 09:53 PM, Nicholas A. Bellinger wrote: > >> /* > >> * Initialize se_cmd for target operation. From this point > >> * exceptions are handled by sending exception status via > > > > Is there another fabric module case where we are actually ever going to > > use this flag..? If not, it should probably stay in UASP code and pass > > the expected data_dir into target_submit_cmd() instead of doing the > > extra re-assignment of a parameter here. > > I'm not aware of any. I could move it into my gadget code and it can be > moved back if another fabric requires it. > Ok, I think that would make sense so we don't pollute target_submit_cmd() with more fabric specific flags than are really necessary.. :) --nab -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
