On 01/09/2012 04:32 PM, Roland Dreier wrote: > Maybe the simplest thing to do is use vmap() on the whole buffer? > The unmap needs a global TLB shootdown but it's not like these > control CDBs are on a fastpath anyway... vmap sounds really good! Will try that. > But OTOH it would be good if we allocate the memory on demand > to handle the 2GB allocation length case I mentioned above, so we > handle the case where an initiator sends us an allocation length > much longer than we actually need. Yeah this seems tricky to do at runtime... > The flip side of that is that we also want to handle the case where > the initiator sends an allocation length shorter than what we need > to return the data. What we're supposed to do in that case is act > like we generated the whole response but truncate the actual data > we return. Looking at the code, this appears to be in place. > You definitely don't have to solve all those problems at once but > we should definitely keep them in mind so we don't make them > harder to solve in the long run. OK, will ponder that. -- Andy -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
