On Tue, 2012-01-03 at 17:12 -0800, Roland Dreier wrote: > From: Marco Sanvido <marco@xxxxxxxxxxxxxxx> > > The comments quote the right parts of the spec: > > * d) Establish a unit attention condition for the > * initiator port associated with every I_T nexus > * that lost its registration other than the I_T > * nexus on which the PERSISTENT RESERVE OUT command > * was received, with the additional sense code set > * to REGISTRATIONS PREEMPTED. > > and > > * e) Establish a unit attention condition for the initiator > * port associated with every I_T nexus that lost its > * persistent reservation and/or registration, with the > * additional sense code set to REGISTRATIONS PREEMPTED; > > but the actual code accidentally uses ASCQ_2AH_RESERVATIONS_PREEMPTED > instead of ASCQ_2AH_REGISTRATIONS_PREEMPTED. Fix this. > > Signed-off-by: Roland Dreier <roland@xxxxxxxxxxxxxxx> > --- > drivers/target/target_core_pr.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/target/target_core_pr.c b/drivers/target/target_core_pr.c > index 95dee70..4911fe9 100644 > --- a/drivers/target/target_core_pr.c > +++ b/drivers/target/target_core_pr.c > @@ -3138,7 +3138,7 @@ static int core_scsi3_pro_preempt( > if (!calling_it_nexus) > core_scsi3_ua_allocate(pr_reg_nacl, > pr_res_mapped_lun, 0x2A, > - ASCQ_2AH_RESERVATIONS_PREEMPTED); > + ASCQ_2AH_REGISTRATIONS_PREEMPTED); > } > spin_unlock(&pr_tmpl->registration_lock); > /* > @@ -3251,7 +3251,7 @@ static int core_scsi3_pro_preempt( > * additional sense code set to REGISTRATIONS PREEMPTED; > */ > core_scsi3_ua_allocate(pr_reg_nacl, pr_res_mapped_lun, 0x2A, > - ASCQ_2AH_RESERVATIONS_PREEMPTED); > + ASCQ_2AH_REGISTRATIONS_PREEMPTED); > } > spin_unlock(&pr_tmpl->registration_lock); > /* Applied to lio-core, and will queue to mainline in the second round of v3.3 target-pending updates later this week. Thanks Roland and Macro! --nab -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
