On Wed, Jan 4, 2012 at 4:54 PM, Roland Dreier <roland@xxxxxxxxxx> wrote: > After discussing this offline with a few people, I now realize we can't > just silently succeed, at least the way my previous patch for data > commands did. (ie that patch is wrong, although better than crashing) > > The problem is that returning immediately like that bypasses the > sequencer, which means we incorrectly skip reservation checking, > returning unit attention, etc. Never mind... I see that generic_new_cmd comes after the sequencer so this doesn't quite apply. However I'm still a bit uncomfortable with adding special handling for REQUEST SENSE, scattering length checks all over the inquiry handling, having a separate buffer and copying in MODE SENSE and all the other ad hoc stuff there is... it would be much better if we could just handle the 0-length stuff uniformly for all the control CDBs. - R. -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
