Re: [PATCH 1/2] target/file: walk properly over sg list

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2011-11-29 at 09:26 +0100, Sebastian Andrzej Siewior wrote:
> On 11/29/2011 01:40 AM, Nicholas A. Bellinger wrote:
> > Ok, I'm applying this patch to lio-core now as it addresses a real issue
> > with fileio backends and loopback LUNs w/ per-chained SGL usage with
> > SCSI LLD incoming struct scsi_cmnd scatterlist memory into target-core.
> >
> > This will need to be Cc'ed to stable as well for v3.1, and I'm adding a
> > more detailed commit log for upstream.
> 
> Okay, cool.
> 
> > Thanks again for catching this!
> 
> np. Did you had the time to look over "target/rd: fix or rewrite the
> copy routine" which depends on "target/rd: use sg_next() while walking
> through the sg list" which fix a similar issue in the ramdisk driver?
> 

I think these look fine.   So applying both of these patches now, and
will do some more testing to verify with ramdisk_mcp and couple of
different fabric drivers using the internal se_cmd->

Well done on this SGL miter bugfix+conversion, and the other
simplification with rd_MEMCPY_do_task() !

Thanks,

--nab





--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux