Re: [PATCH 2/2] target/rd: fix or rewrite the copy routine

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/25/2011 11:06 PM, Jörn Engel wrote:
On Fri, 25 November 2011 22:18:46 +0100, Sebastian Andrzej Siewior wrote:

Okay, I haven't really figured out this copy works in detail and
something here is wring since I lose my data and iblock working.

Any chance this is due to using the wrong page in the previous patch?

I doubt that. Every i++/j++ was replaced by sg_next() which should be doing the same thing.
I've been looking at the following snippet:

                 if (++req->rd_page <= table->page_end_offset) {
                         pr_debug("page: %u in same page table\n",
                                 req->rd_page);
                         continue;
                 }
It increments rd_page and starts over. It never touches i or j so
actually you remain on the same sg. This could be wrong here but I am
not sure.


Jörn

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux