Re: [PATCH] target/rd: use sg_next() while walking through the sg list

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 25 November 2011 18:48:02 +0100, Sebastian Andrzej Siewior wrote:
> On 11/25/2011 06:01 PM, Jörn Engel wrote:
>> On Fri, 25 November 2011 13:38:28 +0100, Sebastian Andrzej Siewior wrote:
>>>
>>> -			src = sg_virt(&sg_s[j++]) + src_offset;
>>> +			src = sg_virt(sg_s) + src_offset;
>>> +			sg_s = sg_next(sg_s);
>> ...
>>> -		sg_s =&table->sg_table[j = 0];
>>> +		sg_s = table->sg_table;
>>
>> Didn't you forget the equivalent of "j = 0" in your patch?
>
> I think the part is the same as
>  j = 0;
>  sg_s = &table->sg_table[0];
>
> which should be the same as
>
>   sg_s = table->sg_table;
>
> So I think I'm fine.

Ah, right.  Looks good to me then.

Jörn

-- 
Doubt is not a pleasant condition, but certainty is an absurd one.
-- Voltaire
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux