On Sun, 2011-11-13 at 22:19 -0800, Roland Dreier wrote: > On Sat, Nov 12, 2011 at 2:14 AM, Nicholas A. Bellinger > <nab@xxxxxxxxxxxxxxx> wrote: > > + kref_init(&se_cmd->cmd_kref); > > + kref_get(&se_cmd->cmd_kref); > > If commands are born with two references, that's magic > enough that I think it at least needs a comment explaining > what the two references are and where they'll be dropped. > So target_get_sess_cmd() will need to support single and double reference cases. Currently tcm_loop, tcm_fc, iscsi_target will be the users of the single reference case, and ib_srpt and tcm_qla2xxx the double reference cases. I'll will get this addressed soon, and add a comment here explaining the two usage cases. Thanks for the feedback Roland! --nab -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
