On Wed, 2011-11-09 at 03:11 -0500, Christoph Hellwig wrote: > On Tue, Nov 08, 2011 at 02:19:41PM -0800, Roland Dreier wrote: > > >> To clarify, I'm not sure that adding target_core_mod symbol dependencies > > >> into the qla2xxx LLD makes sense. ?This would mean target_core_mod would > > >> need to be loaded even when qla2xxx is configured to run in initiator > > >> mode (the presumable default). > > > > > > Which symbol would you pull in? > > > > In my opinion we should keep the dependency one-way, that is > > tcm_qla2xxx depends on qla2xxx. However the way things should > > work IMHO is that tcm_qla2xxx should call a qla2xxx function to > > register itself as a target handler, and that registration function > > should take a struct that tcm_qla2xxx fills in. > > Yes, absolutely - this just has't been the highest priority in my complaints > about the qla2xxx mess yet :) I've been working on this one, and will have something to post later today.. > Now that we have drifted totally offtopic: > can we please move all qla2xxx target code to drivers/scsi/qla2xxx that it > is in one place, rename the separate target shim module to something more > reasonable (qla3xxx-target?), and make sure it is built from a single .c > file instead of spreading it around? > Yep, will take care of both of these points soon. --nab -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
