On Tue, Nov 08, 2011 at 03:17:26PM -0800, Nicholas A. Bellinger wrote: > > And what exactly do we need hardware_lock for? > > > > - tgt_stop is just read, not needed > > - reading the id from the atio structure? I can't see how that could > > trace, but it needs a check from someone who needs the hardware. > > - tcm_qla2xxx_find_sess_by_s_id? doesn't do any lookps, and certainly > > none related to hardware > > This currently needs to be protected by hardware_lock when looking up an > associated se_nacl pointer in vmalloc memory area. Where exactly? Writing down and defitining what locks do is the first step. > > > need to be loaded even when qla2xxx is configured to run in initiator > > > mode (the presumable default). > > > > Which symbol would you pull in? > > > > Just making sure that whatever we call is from tcm_qla2xx to avoid the > two way dependency for initiator mode. :) In the worst case we'll have to add another function pointer indirection. IMHO at this point we should add them basically as needed, and once the driver is in a good shape start to look where the boundaries make sense. -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
