On Sat, 2011-10-22 at 10:47 +0200, Bart Van Assche wrote: > On Sat, Oct 22, 2011 at 10:08 AM, Nicholas A. Bellinger > <nab@xxxxxxxxxxxxxxx> wrote: > > On Tue, 2011-10-18 at 06:51 -0400, Christoph Hellwig wrote: > >> We only need one of them, and they don't have to be modular. Nevermind > >> that we generally never request optional modules. > > > > Without one of these calls into transport_subsystem_check_init(), the > > backend drivers never end up getting loaded with this patch, so I don't > > think it's possible to completely remove the request_module() usage to > > load the extra modules here.. > > What's wrong with an explicit modprobe by the user ? > Fair point, and i'm happy with update userspace to do this. However, requiring a userspace update just to run existing code and breaking existing installations is the concern here for v3.2. So I think the most reasonable compromise would be to use my version of the patch, update init.d/target to load target_core_[iblock,pscsi,fileio], and then completely remove the request_module() calls at a later date once the userspace changes have propagated down to the distributions. --nab -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
