Re: [PATCH 0/8] qla2xxx/tcm_qla2xxx: Merge functions and more renaming.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 2011-10-15 at 16:57 -0500, Madhuranath N Iyengar wrote:
> From: Madhuranath Iyengar <mni@xxxxxxxxxxxxxxx>
> 
> Folks,
> 
> This patch series contains patches below to address the following:
> - Merge some functions with names containing *2xxx* and *24xx*
>   into a single function. In the process some code has been
>   reduced.
> - Rename some more structs and functions. Some renaming has been
>   done as part of the merge function patches. This renaming is
>   in addition to the renaming done with the series of the
>   patches submitted earlier.
> 
> Please have a look and let us know if you have any concerns.
> 
> Thanks.
> 
> Madhuranath Iyengar (8):
>   qla2xxx/tcm_qla2xxx: Merge send term exchange functions in
>     qla_target.c.
>   qla2xxx: Merge notify ack functions in qla_target.c.
>   qla2xxx: Merge send busy functions in qla_target.c.
>   qla2xxx: Merge load data segments functions in qla_target.c.
>   qla2xxx: Merge handle SRR functions in qla_target.c.
>   qla2xxx: Cleanup send and modify lun functions in qla_target.[ch].
>   qla2xxx/tcm_qla2xxx: Rename qla_tgt_2xxx_xmit_response() function.
>   qla2xxx: Rename qla_tgt_24xx_init_ctio_ret_entry() function.
> 
>  drivers/scsi/qla2xxx/qla_target.c               |  874 +++++++++--------------
>  drivers/scsi/qla2xxx/qla_target.h               |   36 +-
>  drivers/target/tcm_qla2xxx/tcm_qla2xxx_fabric.c |   12 +-
>  3 files changed, 358 insertions(+), 564 deletions(-)
> 

Hi Madhu,

These eight patches have been merged into lio-core-2.6.git/master, and
I’m going to let some write-verify tests run overnight just in case..

This includes the following incremental patch to address the SRR
xmit_type breakage that was included in patch #4:

commit bd69bc46562fa14c94f23f37870ad933d9c19883
Author: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx>
Date:   Wed Oct 19 23:35:52 2011 -0700

    qla2xxx: Fix up qla_tgt_handle_srr() xmit_type fallout breakage

But other than this minor bit of fallout, things are looking pretty
good.

Well done on shaving off 200+ LOC from qla_target.c!

--nab

--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux