On Sat, Oct 15, 2011 at 2:57 PM, Madhuranath N Iyengar <mni@xxxxxxxxxxxxxxxxxxxxx> wrote: > + if (IS_FWI2_CAPABLE(ha)) > + iocb = (void *)&imm->imm.imm_ntfy24; > + else > + iocb = (void *)&imm->imm.imm_ntfy; > + > + qla_tgt_send_notify_ack(vha, iocb, 0, 0, 0, > + NOTIFY_ACK_SRR_FLAGS_REJECT, > + NOTIFY_ACK_SRR_REJECT_REASON_UNABLE_TO_PERFORM, > + NOTIFY_ACK_SRR_FLAGS_REJECT_EXPL_NO_EXPL); The code would look even nicer if we could get rid of more of these "if (IS_FWI2_CAPABLE(ha))" tests. And imm_ntfy24 and imm_ntfy point to the same memory anyway. So maybe we could add a void * member to the union (raw_iocb or something?) and not have to worry about HBA type we're running on? - R. -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
