On Wed, 2011-10-12 at 03:37 -0400, Christoph Hellwig wrote: > On Tue, Oct 11, 2011 at 04:24:56PM -0500, Madhuranath N Iyengar wrote: > > From: Madhuranath Iyengar <mni@xxxxxxxxxxxxxxx> > > > > This patch removes the ctio_common_entry_t struct in qla_target.h. In addition > > it renames the ctio_entry_t to ctio_to_2xxx_entry_t and ctio_ret_entry_t to > > ctio_from_2xxx_entry_t for easier understanding of the flow of these structs. > > > > The fields in the ctio_common_entry_t, has been added to the new > > ctio_to_2xxx_entry_t. > > If you rename them it would be good to also drop the typedefs and use > only the struct types. > Christoph, Thanks and appreciate your comments. QLogic has typedef'ed their IOCB structs (say in qla_def.h), and so I maintained the same. If QLogic blesses your suggestion, I'll change them in qla_target.h. Also, I'll wait for comments from others, till EOW before making this or any other changes related to naming or purging. Cheers, Madhu -- -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
