Re: [PATCH-v2 2/2] tcm_qla2xxx: Run ->check_stop_free and ->release_cmd with hardware_lock held

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>> Assuming I merged everything correctly, in my tree sess_cmd_lock looks
>> like it is never taken outside of hardware_lock.  So we can just get
>> rid of the superfluous lock.

> I left that in for the moment as it looks kinda strange to have a
> qla_tgt_sess->sess_cmd_list, but no qla_tgt_sess context lock to protect
> it..

Well, an extra lock is a pretty heavy price to pay just for looks.
How about a comment saying "protected by hardware_lock"?

 - R.
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux