>> Assuming I merged everything correctly, in my tree sess_cmd_lock looks >> like it is never taken outside of hardware_lock. So we can just get >> rid of the superfluous lock. > I left that in for the moment as it looks kinda strange to have a > qla_tgt_sess->sess_cmd_list, but no qla_tgt_sess context lock to protect > it.. Well, an extra lock is a pretty heavy price to pay just for looks. How about a comment saying "protected by hardware_lock"? - R. -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html