Re: [RFC][PATCH 1/5] lib: add unpack_hex_byte()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 20 Sep 2011 09:04:00 +0300 Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote:

> On Tue, Sep 20, 2011 at 1:38 AM, Andrew Morton <akpm@xxxxxxxxxx> wrote:
> >> > Finally, the name is poor. __It starts with "unpack_", so it belongs to
> >> > the "unpack" subsystem. __There's no such thing. __Something like
> >> > hex_byte_to_bin() would be better.
> >>
> >> agreed. __It was suppose to parallel the existing pack_hex_byte().
> >
> > hex_byte_pack() :)
> Have you just proposed to do mass rename of pack_hex_byte() to the
> hex_byte_pack()?

It's very minor, but I suppose we should, if someone feels like it.

We should retain a

char * __deprecated pack_hex_byte(char *buf, u8 byte)
{
	return hex_byte_pack(buf, byte);
}

for a few cycles to minimise harm to out-of-tree code.
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux