On Fri, 2011-09-16 at 23:07 +0900, Tetsuo Handa wrote: > Mimi Zohar wrote: > > Now that hex2bin does error checking, on error add debugging error msg. > > We are waiting for response from Nicholas, aren't we? > Quotuing from http://www.spinics.net/linux/fedora/linux-security-module/msg11570.html : > | I was assuming that, by adding error check, hex2bin() will leave the buffer > | uninitialized in case of bad input because hex2bin() user in Linux 3.0 can > | return errors. Now you are a new user of hex2bin() but your code cannot return > | errors. Nicholas, how do you want to handle bad input? Hi Folks, There is another patch queued for v3.1-final to ensure that non hex characters are skipped in target_emulate_evpd_83() when building the NAA IEEE Registered Extended designator. [PATCH-v2] target: Skip non hex characters for VPD=0x83 NAA IEEE Registered Extended http://www.spinics.net/lists/target-devel/msg00607.html Other than dropping this part from Mimi's patch, the two other warning messages on conversion failure are OK in target_core_fabric_lib.c code. I'm happy to queue a modified version of this one for v3.2. --nab -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
