This series cleans up various lose ends when freeing struct se_cmds.
There are two things I stumbled upon when doing this which rather confuse
me:
(1) what exactly is the purpose of the check_stop_free fabric method.
Generally this ends up as a transport_generic_free_cmd with just
a few notable differences:
- srpt decrements an internal reference count, which ends
up calling transport_generic_free_cmd once it hits zero
- tcm_fc does not ignore TMR requests like all others
- qla2xxxx cals transport_generic_free_cmd for tmr request,
but does not do it for normal requests
I seems rather counter productive to not have a common model
here, and I don't quite understand what qla2xxx and the srp
target are trying to archive
(2) what the point of SCF_SE_LUN_CMD is. As a first a !se_cmd->se_lun
check should give us the same information. But more importantly
why we would ever allow a command without a LUN to stay around,
and more importantly be on core target lists that could lead to
a free.
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
