Re: rtslib bug

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi, late reply to this...

On Tue, Jul 26, 2011 at 8:53 PM, Andy Grover <agrover@xxxxxxxxxx> wrote:
> rtslib/utils.py
>
> def list_eth_ips(ifnames=None):
>    if ifnames is None:
>        ifnames = [iface for iface in list_eth_names() if iface != 'lo']
>    addrs = []
>    for iface in list_eth_names():
>
> this last line should be "for iface in ifnames:"

Thanks, fixed.

>
> Also, how about using python-ethool instead of python-netifaces to get
> ips for an iface? It's a little more widely used.

Well, it is not on PyPi and not in debian.
This is the initial reason why I used netifaces instead.

Regards,
-- 
Jérôme Martin
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux