From: Roland Dreier <roland@xxxxxxxxxxxxxxx> We need to make sure that we don't add new LUNs to dynamic ACLs when tpg_check_demo_mode_login_only=1; otherwise, initiators that are only supposed to see a "not present" virtual LUN 0 will be able to see any LUNs added after they connect. Signed-off-by: Roland Dreier <roland@xxxxxxxxxxxxxxx> --- drivers/target/target_core_device.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c index a066c3e..c0dcf4b 100644 --- a/drivers/target/target_core_device.c +++ b/drivers/target/target_core_device.c @@ -1376,7 +1376,9 @@ struct se_lun *core_dev_add_lun( struct se_node_acl *acl; spin_lock_irq(&tpg->acl_node_lock); list_for_each_entry(acl, &tpg->acl_node_list, acl_list) { - if (acl->dynamic_node_acl) { + if (acl->dynamic_node_acl && + (!tpg->se_tpg_tfo->tpg_check_demo_mode_login_only || + !tpg->se_tpg_tfo->tpg_check_demo_mode_login_only(tpg))) { spin_unlock_irq(&tpg->acl_node_lock); core_tpg_add_node_to_devs(acl, tpg); spin_lock_irq(&tpg->acl_node_lock); -- 1.7.5.4 -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html