On Wed, Aug 17, 2011 at 2:34 PM, Nicholas A. Bellinger <nab@xxxxxxxxxxxxxxx> wrote: > I believe that DMA_TO_DEVICE (from the initiator's perpsective) is set > for bidi operations in struct scsi_cmnd->sc_data_direction, and > include/scsi/scsi_cmnd.h:scsi_in() is used to get the extra bidi READ > buffer. I'm not sure how this is going to work with qla2xxx/tcm_qla2xxx > data_direction yet, but I think it would make sense to do something > similar for qla_tgt_cmd->data_direction. OK, how about if I update my patch to just reverse TO_DEVICE and FROM_DEVICE for mapping buffers, and stick in a comment about how we'll have to figure out bidi later? Longer term / bigger change, maybe it makes sense for the target core not to overload the DMA_xxx enums for its own data direction and something like DATA_TO_TARGET and DATA_FROM_TARGET for LIO use. - R. -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
