re: tcm_fc: Handle DDP/SW fc_frame_payload_get failures in ft_recv_write_data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Kiran,

I had a question resulting from dcd998ccdbf74a7d "tcm_fc: Handle
DDP/SW fc_frame_payload_get failures in ft_recv_write_data"  In
ft_recv_write_data() about half the function is dead code.  What was
intended?

drivers/target/tcm_fc/tfc_io.c
   255          if (f_ctl & FC_FC_SEQ_INIT)
   256                  goto last_frame;
   257          else
   258                  goto drop;
   259  

>From here on down, the code is unreachable.

   260          rel_off = ntohl(fh->fh_parm_offset);
   261          frame_len = fr_len(fp);
   262          if (frame_len <= sizeof(*fh))
   263                  goto drop;

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux