On Fri, 2011-07-22 at 14:50 -0700, Roland Dreier wrote: > From: Roland Dreier <roland@xxxxxxxxxxxxxxx> > > Otherwise it is possible to enable TCM_QLA2XXX without enabling > SCSI_LOWLEVEL, which leads to > > warning: (TCM_QLA2XXX) selects LIBFC which has unmet direct dependencies (SCSI_LOWLEVEL && SCSI) > warning: (TCM_QLA2XXX) selects SCSI_QLA_FC which has unmet direct dependencies (SCSI_LOWLEVEL && PCI && SCSI) > > and the build fails because of missing symbols (because SCSI_FC_ATTRS > doesn't get enabled). > > Signed-off-by: Roland Dreier <roland@xxxxxxxxxxxxxxx> > --- Looks like a reasonable Kconfig change to me.. Committed as 095ccd67f0 into master, and will get these out into lio-4.1-2.6.39 shortly. --nab > drivers/target/tcm_qla2xxx/Kconfig | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/target/tcm_qla2xxx/Kconfig b/drivers/target/tcm_qla2xxx/Kconfig > index 3f6d8c8..7539a87 100644 > --- a/drivers/target/tcm_qla2xxx/Kconfig > +++ b/drivers/target/tcm_qla2xxx/Kconfig > @@ -1,6 +1,7 @@ > config TCM_QLA2XXX > tristate "TCM_QLA2XXX fabric module for Qlogic 2xxx series target mode HBAs" > select LIBFC > + select SCSI_LOWLEVEL > select SCSI_QLA_FC > default n > ---help--- -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
