Re: [PATCH] target/iblock: Remove unused iblock_dev.ibd_depth member

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 29, 2011 at 07:52:39AM -0700, Roland Dreier wrote:
> > ibd_force seems to be just as dead, and ibd_major/minor are only used
> > for a printk that could get it's dev_t from ibd_bd.  Furthermore the
> > IBDF_HAS_FORCE flag for ibd_flags is dead, too.  And the iblock_host_id
> > field in struct iblock_hba (the only field in it) is only used for
> > pretty useless printks.  Seems like there's a lot more fat to trim :)
> 
> The force option seems exposed to user space.  Do you think we should get
> rid of that parsing or just parse it and ignore it?

Parsing and ignoring is what we do right now anyway.  No need to store
it in a structure member that never gets read.
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux