Re: Fwd: System fails to create zram on startup, but I can do so manually

[Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx>]

On Mon, Nov 25, 2024 at 04:17:03PM +0100, Michal Koutný wrote:
> On Wed, Nov 20, 2024 at 02:58:57PM GMT, Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> wrote:
> > I don't think we can change this now, because this was documented
> > behaviour and people may have used something like '4k' to get 4000 MB.
> 
> If you're referring to 
> ae46c78 ("Obsolete zram-fraction and max-zram-size in favour of new, arbitrary-expression, zram-size"
> it also quite unfortunately removed units from the manpage.
> So, technically speaking behavior of 4k was undocumented.

It's all actually documented in the readme and examples. If docs are
missing somewhere, we should improve that.

After sleeping a bit on this, I'm not sure if it's worth the trouble.
It hasn't come up before, it seems most people put 'ram * 0.5' or
something like that. As a much simpler solution, we could just add
a warning if the configured value is much too large, e.g. above 100*ram.

WDYT?

> > I think the nice backwards-compatible solution would
> > be to add a new setting, e.g. disk-size that is evaluated as bytes,
> > and soft-deprecate zram-size.
> 
> Please Cc me (Werkov) on any related PR.

Zbyszek