On Sat, Nov 16, 2019 at 11:54 AM Michael Biebl <mbiebl@xxxxxxxxx> wrote:
Am Sa., 16. Nov. 2019 um 09:20 Uhr schrieb Andrei Borzenkov
<arvidjaar@xxxxxxxxx>:
>
> Likely result of mass-rewrite in
>
> commit 25de7aa7b90c23d33ea50ada1e50c5834a414237
> Author: Yu Watanabe <watanabe.yu+github@xxxxxxxxx>
> Date: Thu Apr 25 01:21:11 2019 +0200
>
> udev: modernize udev-rules.c
A bug then? Or is there an error in the udev rule that I don't see?
IMHO it is a bug, since it asks for the wrong operator...
As far as I know, IMPORT{} is not a list, it has immediate effect on the following rules, so it is normally used with simple assignment '='. (So although '+=' *could* be accepted, it would practically mean the exact same thing as '='.)
And even though the error message recommends '==', I don't see how that would make sense since IMPORT is by definition an update and not a comparison. There are two dm rules using IMPORT{}=="..." and it really seems like they should be using '=' instead.
It seems that the old code accepted literally any operator except '-=', so maybe that's where the weird rules with '==' and '+=' come from.
Mantas Mikulėnas
_______________________________________________ systemd-devel mailing list systemd-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/systemd-devel
