Hi Lennart,
I've applied the coding style guidelines, and created a pull request
#12768 via GitHub. Let me know what I may have done wrong, my first
attempt via GitHub.
Thanks,
eric
On 5/16/19 9:34 AM, Lennart Poettering wrote:
On Do, 16.05.19 09:28, Eric DeVolder (eric.devolder@xxxxxxxxxx) wrote:
Could you please submit this via github as PR? Review is so much nicer
there, in particular for complex patch sets, and this qualifies as
complex I think. This also has the benefit that the code is
automatically analyzed by our CI tools.
https://github.com/systemd/systemd/pulls
Moreover, please make sure to to read our coding style guidelines
here:
https://systemd.io/CODING_STYLE
Form a very brief glance it appears the code doesn't follow formatting
rules for example.
Thanks!
Lennart
--
Lennart Poettering, Berlin
_______________________________________________
systemd-devel mailing list
systemd-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/systemd-devel
