Running a service *just* before unmounting filesystems

[hdegoede@xxxxxxxxxx (Hans de Goede)]

Hi,

On 13-06-18 17:05, Zbigniew JÄ?drzejewski-Szmek wrote:
> On Wed, Jun 13, 2018 at 04:55:27PM +0200, Hans de Goede wrote:
>> Hi,
>>
>> On 12-06-18 19:11, Lennart Poettering wrote:
>>> On Di, 12.06.18 11:33, Hans de Goede (hdegoede at redhat.com) wrote:
>>>> AFAIK the service actually doing the updates is supposed to call
>>>> systemctl reboot --force when it is done, so any targets after
>>>> system-update.target won't get started ?
>>>
>>> True, the service in question could split the reboot call of course,
>>> if it wanted, so that you can plug things in between.
>>
>> Since in this case we want to increment a boot_indeterminate counter
>> to indicate the last boot was not a normal boot, so no clear
>> success status is available I'm fine with the service doing the
>> increment before the updates run.
>>
>> So I was thinking about adding a system-update-pre.target
>> and then in system-update.target add:
>>
>> Wants=system-update-pre.target
>> After=system-update-pre.target
> Yep, that sounds reasonable.

Ok, so as you've already seen I've just send a pull-req with
this change:

https://github.com/systemd/systemd/pull/9334

Given that we're going to need system-update-pre.target for Fedora 29:
https://fedoraproject.org/wiki/Changes/HiddenGrubMenu

It would be great if this could still make the upcoming 239
release. But I guess it is too late for that?

Assuming this is too late, I would like to request to carry
this as a downstream patch in the Fedora pkgs for now.

Regards,

Hans