This is a note to let you know that I've just added the patch titled
[media] cx24117: fix a buffer overflow when checking userspace params
to the 3.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
cx24117-fix-a-buffer-overflow-when-checking-userspace-params.patch
and it can be found in the queue-3.14 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From 82e3b88b679049f043fe9b03991d6d66fc0a43c8 Mon Sep 17 00:00:00 2001
From: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxx>
Date: Tue, 28 Apr 2015 19:03:59 -0300
Subject: [media] cx24117: fix a buffer overflow when checking userspace params
From: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxx>
commit 82e3b88b679049f043fe9b03991d6d66fc0a43c8 upstream.
The maximum size for a DiSEqC command is 6, according to the
userspace API. However, the code allows to write up much more values:
drivers/media/dvb-frontends/cx24116.c:983 cx24116_send_diseqc_msg() error: buffer overflow 'd->msg' 6 <= 23
Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/media/dvb-frontends/cx24117.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/media/dvb-frontends/cx24117.c
+++ b/drivers/media/dvb-frontends/cx24117.c
@@ -1043,7 +1043,7 @@ static int cx24117_send_diseqc_msg(struc
dev_dbg(&state->priv->i2c->dev, ")\n");
/* Validate length */
- if (d->msg_len > 15)
+ if (d->msg_len > sizeof(d->msg))
return -EINVAL;
/* DiSEqC message */
Patches currently in stable-queue which might be from mchehab@xxxxxxxxxxxxxxx are
queue-3.14/cx24116-fix-a-buffer-overflow-when-checking-userspace-params.patch
queue-3.14/saa7164-fix-querycap-warning.patch
queue-3.14/s5h1420-fix-a-buffer-overflow-when-checking-userspace-params.patch
queue-3.14/cx24117-fix-a-buffer-overflow-when-checking-userspace-params.patch
queue-3.14/af9013-don-t-accept-invalid-bandwidth.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html