Re: [PATCH 2/5] usb: gadget: mass_storage: Enforce contiguous LUN ids

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 22 Jun 2015, Michal Nazarewicz wrote:

> On Mon, Jun 22 2015, Krzysztof Opasiak wrote:
> > According to mass storage specification:
> >
> > "Logical Unit Numbers on the device shall be numbered contiguously
> >  starting from LUN 0 to a maximum LUN of 15 (Fh)"
> >
> > So don't allow to bind ms function unless we have at least LUN0
> > and LUNs ids are contiguous.
> >
> > Signed-off-by: Krzysztof Opasiak <k.opasiak@xxxxxxxxxxx>
> 
> Acked-by: Michal Nazarewicz <mina86@xxxxxxxxxx>
> 
> but then again I think that we should let user space shoot themselves in
> the foot if they want to, especially as letting them to that is less
> code. ;)

How about logging a warning message if the LUNs aren't contiguous but 
then continuing on?  Like we do if the serial number string isn't 
provided.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe stable" in



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]