Re: [PATCH] regulator: core: fix constraints debug output

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2015-05-20 at 20:17 +0000, Stefan Wahren wrote:
> In the case uV_offset is greater than 0 the debug output before
> is accidentally overwritten. So take care of the output count.

If you are going to take care, please change all of these
sprintf calls to snprintf.

The buf array may not be big enough [80] to hold the longest
possible output string.

> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
[]
> @@ -801,7 +801,7 @@ static void print_constraints(struct regulator_dev *rdev)
>  	}
>  
>  	if (constraints->uV_offset)
> -		count += sprintf(buf, "%dmV offset ",
> +		count += sprintf(buf + count, "%dmV offset ",
>  				 constraints->uV_offset / 1000);
>  
>  	if (constraints->min_uA && constraints->max_uA) {



--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]