Re: [PATCH] arm64: psci: move psci firmware calls out of line

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 15, 2015 at 10:30 AM, Kevin Hilman <khilman@xxxxxxxxxx> wrote:
> From: Will Deacon <will.deacon@xxxxxxx>
>
> An arm64 allmodconfig fails to build with GCC 5 due to __asmeq
> assertions in the PSCI firmware calling code firing due to mcount
> preambles breaking our assumptions about register allocation of function
> arguments:
>
>   /tmp/ccDqJsJ6.s: Assembler messages:
>   /tmp/ccDqJsJ6.s:60: Error: .err encountered
>   /tmp/ccDqJsJ6.s:61: Error: .err encountered
>   /tmp/ccDqJsJ6.s:62: Error: .err encountered
>   /tmp/ccDqJsJ6.s:99: Error: .err encountered
>   /tmp/ccDqJsJ6.s:100: Error: .err encountered
>   /tmp/ccDqJsJ6.s:101: Error: .err encountered
>
> This patch fixes the issue by moving the PSCI calls out-of-line into
> their own assembly files, which are safe from the compiler's meddling
> fingers.
>
> Reported-by: Andy Whitcroft <apw@xxxxxxxxxxxxx>
> Signed-off-by: Will Deacon <will.deacon@xxxxxxx>
> Signed-off-by: Catalin Marinas <catalin.marinas@xxxxxxx>
> Cc: <stable@xxxxxxxxxxxxxxx> # v3.18
> (cherry picked from commit f5e0a12ca2d939e47995f73428d9bf1ad372b289)
> Signed-off-by: Kevin Hilman <khilman@xxxxxxxxxx>
> ---
> This commit is already applied to v3.19+ stable trees, but is also
> needed in v3.18, but didn't apply cleanly.  This patch is a backport
> which fixed up a minor conflict in the Makefile so that it applies
> cleanly to v3.18.

Oops, please ignore this one.  It was the wrong backport and will not
apply cleanly to v3.18.  I'll resend the right one shortly.

Kevin
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]