Re: [PATCH 1/4] ACPICA: Tables: Change acpi_find_root_pointer() to use acpi_physical_address.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Greg,

On Thu, May 14, 2015 at 06:43:40PM -0700, Greg KH wrote:
> On Tue, May 12, 2015 at 05:28:19PM -0400, George G. Davis wrote:
> > From: Lv Zheng <lv.zheng@xxxxxxxxx>
> > 
> > commit f254e3c57b9d952e987502aefa0804c177dd2503 upstream.
> > 
> > ACPICA commit 7d9fd64397d7c38899d3dc497525f6e6b044e0e3
> > 
> > OSPMs like Linux expect an acpi_physical_address returning value from
> > acpi_find_root_pointer(). This triggers warnings if sizeof (acpi_size) doesn't
> > equal to sizeof (acpi_physical_address):
> >   drivers/acpi/osl.c:275:3: warning: passing argument 1 of 'acpi_find_root_pointer' from incompatible pointer type [enabled by default]
> >   In file included from include/acpi/acpi.h:64:0,
> >                    from include/linux/acpi.h:36,
> >                    from drivers/acpi/osl.c:41:
> >   include/acpi/acpixf.h:433:1: note: expected 'acpi_size *' but argument is of type 'acpi_physical_address *'
> > This patch corrects acpi_find_root_pointer().
> > 
> > Link: https://github.com/acpica/acpica/commit/7d9fd643
> > Signed-off-by: Lv Zheng <lv.zheng@xxxxxxxxx>
> > Signed-off-by: Bob Moore <robert.moore@xxxxxxxxx>
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> > Signed-off-by: Dirk Behme <dirk.behme@xxxxxxxxx>
> > Signed-off-by: George G. Davis <george_davis@xxxxxxxxxx>
> > ---
> >  drivers/acpi/acpica/tbxfroot.c | 7 ++++---
> >  include/acpi/acpixf.h          | 2 +-
> >  2 files changed, 5 insertions(+), 4 deletions(-)
> 
> Why shouldn't this patch also be in 4.0-stable?

Apologies, I did not intend to imply that these commits should only be
applied to v3.14 stable.  It just happens to be the version we're
using.

> I don't want to take
> patches in one tree and not others.
> 
> Same for the other patches in this series.

It looks as if the upstream commit which causes this issue, "2b87601
ACPICA: Utilities: split IO address types from data type models.", has
been applied to v3.10, v3.14, v3.19, and v4.0 stable branches.  So all
of the commits in this series will be required for each of those stable
release branches, to resolve the ARCH=i386 ACPI build warnings which
should exist in each of those stable branches.

Thanks!

--
Regards,
George

> 
> thanks,
> 
> greg k-h
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]