On Sun, Apr 26, 2015 at 11:17:46PM -0400, Sasha Levin wrote: > On 04/26/2015 06:30 AM, Guenter Roeck wrote: > > Hi, > > > > almost all builds in v3.18-stable-queue fail with > > > > In file included from net/socket.c:74:0: > > include/linux/if_vlan.h: In function 'vlan_put_tag': > > include/linux/if_vlan.h:409:3: error: implicit declaration of function '__vlan_put_tag' [-Werror=implicit-function-declaration] > > include/linux/if_vlan.h:409:3: warning: return makes pointer from integer without a cast [enabled by default] > > > > groeck@server:~/src/linux-stable$ git grep __vlan_put_tag > > include/linux/if_vlan.h: return __vlan_put_tag(skb, vlan_proto, vlan_tci); > > > > It appears that 'vlan: rename __vlan_put_tag to vlan_insert_tag_set_proto' was incomplete > > for v3.18. > > Thanks! > > This was actually missing b4bef1b575 ("vlan: kill vlan_put_tag helper"). > > Fixed and re-pushed. > Hi Sasha, much better now but there are still several build failures. drivers/net/ethernet/broadcom/bnx2x/bnx2x.h: In function 'bnx2x_fp_busy_poll_init': drivers/net/ethernet/broadcom/bnx2x/bnx2x.h:625:2: error: implicit declaration of function 'WRITE_ONCE' --- drivers/net/vxlan.c: In function 'vxlan_xmit_skb': drivers/net/vxlan.c:1646:2: error: too few arguments to function 'iptunnel_handle_offloads' include/net/ip_tunnels.h:181:17: note: declared here Guenter -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html