On Fri, Apr 10, 2015 at 06:49:35PM -0700, Vinson Lee wrote: > Hi. > > Please review upstream 3.18 commit > 351fc4a99d49fde63fe5ab7412beb35c40d27269 "sb_edac: avoid INTERNAL > ERROR message in EDAC with unspecified channel" for stable trees < > 3.18. > Thanks, I'll queue it for the 3.16 kernel. Cheers, -- Luís > I'm not sure how far back this patch should go to but it appears it is > applicable at least as far back as 3.10. > > commit 351fc4a99d49fde63fe5ab7412beb35c40d27269 > Author: Seth Jennings <sjenning@xxxxxxxxxx> > Date: Fri Sep 5 14:28:47 2014 -0500 > > sb_edac: avoid INTERNAL ERROR message in EDAC with unspecified channel > > Intel IA32 SDM Table 15-14 defines channel 0xf as 'not specified', but > EDAC doesn't know about this and returns and INTERNAL ERROR when the > channel is greater than NUM_CHANNELS: > > kernel: [ 1538.886456] CPU 0: Machine Check Exception: 0 Bank 1: > 940000000000009f > kernel: [ 1538.886669] TSC 2bc68b22e7e812 ADDR 46dae7000 MISC 0 > PROCESSOR 0:306e4 TIME 1390414572 SOCKET 0 APIC 0 > kernel: [ 1538.971948] EDAC MC1: INTERNAL ERROR: channel value is > out of range (15 >= 4) > kernel: [ 1538.972203] EDAC MC1: 0 CE memory read error on unknown > memory (slot:0 page:0x46dae7 offset:0x0 grain:0 syndrome:0x0 - > area:DRAM err_code:0000:009f socket:1 channel_mask:1 rank:0) > > This commit changes sb_edac to forward a channel of -1 to EDAC if the > channel is not specified. edac_mc_handle_error() sets the channel to -1 > internally after the error message anyway, so this commit should have no > effect other than avoiding the INTERNAL ERROR message when the channel > is not specified. > > Signed-off-by: Seth Jennings <sjenning@xxxxxxxxxx> > Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxx> > > > Cheers, > Vinson > -- > To unsubscribe from this list: send the line "unsubscribe stable" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html