On Fri, Apr 03, 2015 at 12:25:49PM +0200, Jiri Slaby wrote: > Hi, > > to me, it seems that 3.10 & 3.14 contain > fd66fc1cafd72ddf27dbec3a5e29e99839d1bc84 (iwlwifi: mvm: fix failure path > when power_update fails in add_interface) which is IMO misapplied. The > commit should be dropped. See: > > ret = iwl_mvm_mac_ctxt_add(mvm, vif); > if (ret) > - goto out_release; > + goto out_remove_mac; > > remove_mac in case mac_add failed? > > The original was: > ret = iwl_mvm_power_update_mac(mvm); > if (ret) > - goto out_release; > + goto out_remove_mac; > > In 3.10: fce2d025479af5e1fa6717480c7853cdfb8b71aa > In 3.14: 5ac97a1b97e50ef197b64b72c1cd71779e4ecbbe Thanks, I've now reverted these. greg k-h -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html