This is a note to let you know that I've just added the patch titled
target: Fix virtual LUN=0 target_configure_device failure OOPs
to the 3.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
target-fix-virtual-lun-0-target_configure_device-failure-oops.patch
and it can be found in the queue-3.14 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From 5f7da044f8bc1cfb21c962edf34bd5699a76e7ae Mon Sep 17 00:00:00 2001
From: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx>
Date: Thu, 5 Mar 2015 03:28:24 +0000
Subject: target: Fix virtual LUN=0 target_configure_device failure OOPs
From: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx>
commit 5f7da044f8bc1cfb21c962edf34bd5699a76e7ae upstream.
This patch fixes a NULL pointer dereference triggered by a late
target_configure_device() -> alloc_workqueue() failure that results
in target_free_device() being called with DF_CONFIGURED already set,
which subsequently OOPses in destroy_workqueue() code.
Currently this only happens at modprobe target_core_mod time when
core_dev_setup_virtual_lun0() -> target_configure_device() fails,
and the explicit target_free_device() gets called.
To address this bug originally introduced by commit 0fd97ccf45, go
ahead and move DF_CONFIGURED to end of target_configure_device()
code to handle this special failure case.
Reported-by: Claudio Fleiner <cmf@xxxxxxxxxxxxx>
Cc: Claudio Fleiner <cmf@xxxxxxxxxxxxx>
Cc: Christoph Hellwig <hch@xxxxxx>
Signed-off-by: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/target/target_core_device.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/drivers/target/target_core_device.c
+++ b/drivers/target/target_core_device.c
@@ -1591,8 +1591,6 @@ int target_configure_device(struct se_de
ret = dev->transport->configure_device(dev);
if (ret)
goto out;
- dev->dev_flags |= DF_CONFIGURED;
-
/*
* XXX: there is not much point to have two different values here..
*/
@@ -1654,6 +1652,8 @@ int target_configure_device(struct se_de
list_add_tail(&dev->g_dev_node, &g_device_list);
mutex_unlock(&g_device_mutex);
+ dev->dev_flags |= DF_CONFIGURED;
+
return 0;
out_free_alua:
Patches currently in stable-queue which might be from nab@xxxxxxxxxxxxxxx are
queue-3.14/iscsi-target-avoid-early-conn_logout_comp-for-iser-connections.patch
queue-3.14/target-pscsi-fix-null-pointer-dereference-in-get_device_type.patch
queue-3.14/target-fix-virtual-lun-0-target_configure_device-failure-oops.patch
queue-3.14/target-allow-write-exclusive-non-reservation-holders-to-read.patch
queue-3.14/target-avoid-dropping-allregistrants-reservation-during-unregister.patch
queue-3.14/target-fix-reference-leak-in-target_get_sess_cmd-error-path.patch
queue-3.14/target-allow-allregistrants-to-re-reserve-existing-reservation.patch
queue-3.14/target-fix-r_holder-bit-usage-for-allregistrants.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html