On 03/18/2015, 11:54 AM, Takashi Iwai wrote: > commit a1f3f1ca66bd12c339b17a0c2ef93a093f90a277 upstream. > > The commit [63e51fd708f5: ALSA: hda - Don't take unresponsive D3 > transition too serious] introduced a conditional fallback behavior to > the HD-audio controller depending on the flag set. However, it > introduced a silly bug, too, that the flag was evaluated in a reverse > way. This resulted in a regression of HD-audio controller driver > where it can't go to the fallback mode at communication errors. > > Unfortunately (or fortunately?) this didn't come up until recently > because the affected code path is an error handling that happens only > on an unstable hardware chip. Most of recent chips work stably, thus > they didn't hit this problem. Now, we've got a regression report with > a VIA chip, and this seems indeed requiring the fallback to the > polling mode, and finally the bug was revealed. > > The fix is a oneliner to remove the wrong logical NOT in the check. > (Lesson learned - be careful about double negation.) > > The bug should be backported to stable, but the patch won't be > applicable to 3.13 or earlier because of the code splits. The stable > fix patches for earlier kernels will be posted later manually. > > [... and this is the manual patch -- tiwai] Applied to 3.12. Thanks! -- js suse labs -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html