On Wed, Mar 19, 2025 at 5:26 PM Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > On Wed, Mar 19, 2025 at 03:44:19PM +0100, Jan Stancek wrote: > > On Wed, Mar 19, 2025 at 07:13:13AM -0700, Greg Kroah-Hartman wrote: > > > On Wed, Mar 19, 2025 at 02:40:31PM +0800, Huacai Chen wrote: > > > > From: Jan Stancek <jstancek@xxxxxxxxxx> > > > > > > > > commit 558bdc45dfb2669e1741384a0c80be9c82fa052c upstream. > > > > > > > > ENGINE API has been deprecated since OpenSSL version 3.0 [1]. > > > > Distros have started dropping support from headers and in future > > > > it will likely disappear also from library. > > > > > > > > It has been superseded by the PROVIDER API, so use it instead > > > > for OPENSSL MAJOR >= 3. > > > > > > > > [1] https://github.com/openssl/openssl/blob/master/README-ENGINES.md > > > > > > > > [jarkko: fixed up alignment issues reported by checkpatch.pl --strict] > > > > > > > > Signed-off-by: Jan Stancek <jstancek@xxxxxxxxxx> > > > > Reviewed-by: Jarkko Sakkinen <jarkko@xxxxxxxxxx> > > > > Tested-by: R Nageswara Sastry <rnsastry@xxxxxxxxxxxxx> > > > > Reviewed-by: Neal Gompa <neal@xxxxxxxxx> > > > > Signed-off-by: Jarkko Sakkinen <jarkko@xxxxxxxxxx> > > > > Signed-off-by: Huacai Chen <chenhuacai@xxxxxxxxxxx> > > > > --- > > > > certs/extract-cert.c | 103 ++++++++++++++++++++++++++++++------------- > > > > scripts/sign-file.c | 93 ++++++++++++++++++++++++++------------ > > > > 2 files changed, 138 insertions(+), 58 deletions(-) > > > > > > This seems to differ from what is upstream by a lot, please document > > > what you changed from it and why when you resend this series again. > > > > Hunks are arranged differently, but code appears to be identical. > > When I apply the series to v6.6.83 and compare with upstream I get: > > If so, why is the diffstat different? Also why are the hunks arranged > differently, He appears to be using "--diff-algorithm=minimal", while you probably patience or histogram. $ git format-patch -1 --stdout --diff-algorithm=minimal 558bdc45dfb2 | grep -A3 -m1 -- "---" --- certs/extract-cert.c | 103 ++++++++++++++++++++++++++++++------------- scripts/sign-file.c | 93 ++++++++++++++++++++++++++------------ 2 files changed, 138 insertions(+), 58 deletions(-) Should be easy to regenerate with different diff-alg for v4. Regards, Jan > that's a hint to me that something went wrong and I can't > trust the patch at all. > > thanks, > > greg k-h >
