Re: [PATCH 6.6.y 1/2] wifi: rtw89: pci: add pre_deinit to be called

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On Tue, Mar 11, 2025 at 04:10:00PM +0800, Zenm Chen wrote:
> > From: Ping-Ke Shih <pkshih@xxxxxxxxxxx>
> > 
> > [ Upstream commit 9e1aff437a560cd72cb6a60ee33fe162b0afdaf1 ]
> > 
> > At probe stage, we only do partial initialization to enable ability to
> > download firmware and read capabilities. After that, we use this pre_deinit
> > to disable HCI to save power.
> > 
> > Signed-off-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>
> > Signed-off-by: Kalle Valo <kvalo@xxxxxxxxxx>
> > Link: https://lore.kernel.org/r/20231110012319.12727-4-pkshih@xxxxxxxxxxx
> > [ Zenm: minor fix to make it apply on 6.6.y ]
> 
> That was not "minor" changes, as your diff looks like:
> 
> > Signed-off-by: Zenm Chen <zenmchen@xxxxxxxxx>
> > ---
> >  drivers/net/wireless/realtek/rtw89/core.c | 2 ++
> >  drivers/net/wireless/realtek/rtw89/core.h | 6 ++++++
> >  drivers/net/wireless/realtek/rtw89/pci.c  | 8 ++++++++
> >  3 files changed, 16 insertions(+)
>
> But the original was:
>  drivers/net/wireless/realtek/rtw89/core.c   |    2 ++
>  drivers/net/wireless/realtek/rtw89/core.h   |    6 ++++++
>  drivers/net/wireless/realtek/rtw89/pci.c    |    2 ++
>  drivers/net/wireless/realtek/rtw89/pci.h    |   12 ++++++++++++
>  drivers/net/wireless/realtek/rtw89/pci_be.c |   18 ++++++++++++++++++
>  drivers/net/wireless/realtek/rtw89/reg.h    |    9 +++++++++
>  6 files changed, 49 insertions(+)
> 
> That is a big difference.
> 
> Please either backport the whole thing, or document exactly what you
> changed here.  Otherwise this looks like a totally new patch and we
> can't take that for obvious reasons.

Hi Greg,

Sorry about that, I will explain more clearly about the changes in v2, 
please drop this patch series, thanks!

>
> thanks,
>
> greg k-h





[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux