RE: [PATCH v2 1/1] usb: common: otg-fsm: only signal connect after switching to peripheral

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



 
> 
> On Wed, Mar 11, 2015 at 02:37:45PM +0800, Peter Chen wrote:
> > We should signal connect (pull up dp) after we have already at
> > peripheral mode, otherwise, the dp may be toggled due to we reset
> > controller or do disconnect during the initialization for peripheral,
> > then, the host may be confused during the enumeration, eg, it finds
> > the reset can't succeed, but the device is still there, see below
> > error message.
> >
> > hub 1-0:1.0: USB hub found
> > hub 1-0:1.0: 1 port detected
> > hub 1-0:1.0: cannot reset port 1 (err = -32) hub 1-0:1.0: cannot reset
> > port 1 (err = -32) hub 1-0:1.0: cannot reset port 1 (err = -32) hub
> > 1-0:1.0: cannot reset port 1 (err = -32) hub 1-0:1.0: cannot reset
> > port 1 (err = -32) hub 1-0:1.0: Cannot enable port 1.  Maybe the USB
> > cable is bad?
> > hub 1-0:1.0: cannot reset port 1 (err = -32) hub 1-0:1.0: cannot reset
> > port 1 (err = -32) hub 1-0:1.0: cannot reset port 1 (err = -32) hub
> > 1-0:1.0: cannot reset port 1 (err = -32) hub 1-0:1.0: cannot reset
> > port 1 (err = -32) hub 1-0:1.0: Cannot enable port 1.  Maybe the USB
> > cable is bad?
> > hub 1-0:1.0: cannot reset port 1 (err = -32) hub 1-0:1.0: cannot reset
> > port 1 (err = -32) hub 1-0:1.0: cannot reset port 1 (err = -32) hub
> > 1-0:1.0: cannot reset port 1 (err = -32) hub 1-0:1.0: cannot reset
> > port 1 (err = -32) hub 1-0:1.0: Cannot enable port 1.  Maybe the USB
> > cable is bad?
> > hub 1-0:1.0: cannot reset port 1 (err = -32) hub 1-0:1.0: cannot reset
> > port 1 (err = -32) hub 1-0:1.0: cannot reset port 1 (err = -32) hub
> > 1-0:1.0: cannot reset port 1 (err = -32) hub 1-0:1.0: cannot reset
> > port 1 (err = -32) hub 1-0:1.0: Cannot enable port 1.  Maybe the USB
> > cable is bad?
> > hub 1-0:1.0: unable to enumerate USB device on port 1
> >
> > Cc: stable@xxxxxxxxxxxxxxx
> 
> which commit are you fixing ? You need something like:
> 
> Fixes: 123456789012 ("commit short description")
> Cc: <stable@xxxxxxxxxxxxxxx> # vX.Y+

This issue was existed before v3.0, I will add at next version, thanks.

Peter 
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]