On Wed, 5 Mar 2025 13:46:21 -0800 Haiyang Zhang wrote:
> - for (i = 0; i < max_num_devs; i++) {
> + for (i = 0; i < GDMA_DEV_LIST_SIZE &&
> + found_dev < resp.num_of_devs; i++) {
unfortunate mis-indent here, it blend with the code.
checkpatch is right that it should be aligned with opening bracket
> dev = resp.devs[i];
> dev_type = dev.type;
>
> + /* Skip empty devices */
> + if (dev.as_uint32 == 0)
> + continue;
> +
> + found_dev++;
> + dev_info(gc->dev, "Got devidx:%u, type:%u, instance:%u\n", i,
> + dev.type, dev.instance);
Are you sure you want to print this info message for each device,
each time it's probed? Seems pretty noisy. We generally recommend
printing about _unusual_ things.
